From c360b5fb498985ca8d351e9c9d518b0d78b834ba Mon Sep 17 00:00:00 2001 From: =?utf8?q?Timm=20B=C3=A4der?= Date: Fri, 5 Feb 2016 10:00:46 +0100 Subject: [PATCH] Remove more unnecessary redraws The call to gtk_widget_set_state_flags immediately before these already queues a redraw/allocate/resize in case they have to be queued. --- gtk/gtkcolorchooserwidget.c | 6 +----- gtk/gtkcombobox.c | 2 -- gtk/gtkflowbox.c | 2 -- gtk/gtklistbox.c | 2 -- gtk/gtkwindow.c | 2 -- 5 files changed, 1 insertion(+), 13 deletions(-) diff --git a/gtk/gtkcolorchooserwidget.c b/gtk/gtkcolorchooserwidget.c index c51144c1f7..523219d9a5 100644 --- a/gtk/gtkcolorchooserwidget.c +++ b/gtk/gtkcolorchooserwidget.c @@ -105,14 +105,10 @@ select_swatch (GtkColorChooserWidget *cc, return; if (cc->priv->current != NULL) - { - gtk_widget_unset_state_flags (GTK_WIDGET (cc->priv->current), GTK_STATE_FLAG_SELECTED); - gtk_widget_queue_draw (GTK_WIDGET (cc->priv->current)); - } + gtk_widget_unset_state_flags (GTK_WIDGET (cc->priv->current), GTK_STATE_FLAG_SELECTED); gtk_widget_set_state_flags (GTK_WIDGET (swatch), GTK_STATE_FLAG_SELECTED, FALSE); cc->priv->current = swatch; - gtk_widget_queue_draw (GTK_WIDGET (cc->priv->current)); gtk_color_swatch_get_rgba (swatch, &color); diff --git a/gtk/gtkcombobox.c b/gtk/gtkcombobox.c index 628f708d47..de843eede6 100644 --- a/gtk/gtkcombobox.c +++ b/gtk/gtkcombobox.c @@ -1648,8 +1648,6 @@ gtk_combo_box_button_state_flags_changed (GtkWidget *widget, gtk_widget_get_state_flags (widget), TRUE); } - - gtk_widget_queue_draw (widget); } static void diff --git a/gtk/gtkflowbox.c b/gtk/gtkflowbox.c index 9f6d4beeb8..364474494c 100644 --- a/gtk/gtkflowbox.c +++ b/gtk/gtkflowbox.c @@ -993,8 +993,6 @@ gtk_flow_box_child_set_selected (GtkFlowBoxChild *child, gtk_widget_unset_state_flags (GTK_WIDGET (child), GTK_STATE_FLAG_SELECTED); - gtk_widget_queue_draw (GTK_WIDGET (child)); - return TRUE; } diff --git a/gtk/gtklistbox.c b/gtk/gtklistbox.c index 3b2c1ac2b6..f2a35b850e 100644 --- a/gtk/gtklistbox.c +++ b/gtk/gtklistbox.c @@ -1911,7 +1911,6 @@ gtk_list_box_multipress_gesture_pressed (GtkGestureMultiPress *gesture, gtk_widget_set_state_flags (GTK_WIDGET (priv->active_row), GTK_STATE_FLAG_ACTIVE, FALSE); - gtk_widget_queue_draw (GTK_WIDGET (box)); if (n_press == 2 && !priv->activate_single_click) gtk_list_box_activate (box, row); @@ -1989,7 +1988,6 @@ gtk_list_box_multipress_gesture_released (GtkGestureMultiPress *gesture, priv->active_row = NULL; priv->active_row_active = FALSE; - gtk_widget_queue_draw (GTK_WIDGET (box)); g_object_unref (box); } diff --git a/gtk/gtkwindow.c b/gtk/gtkwindow.c index d86f74fc11..c2a83e0a21 100644 --- a/gtk/gtkwindow.c +++ b/gtk/gtkwindow.c @@ -11921,8 +11921,6 @@ ensure_state_flag_backdrop (GtkWidget *widget) gtk_widget_set_state_flags (widget, GTK_STATE_FLAG_BACKDROP, FALSE); else gtk_widget_unset_state_flags (widget, GTK_STATE_FLAG_BACKDROP); - - gtk_widget_queue_draw (widget); } void -- 2.30.2